Christian Brabandt wrote:
> On Di, 19 Jul 2016, Bram Moolenaar wrote:
>
> > Some files have low coverage, for example digraph.c has only 9%
> > coverage:
> > https://coveralls.io/builds/7070119/source?filename=src%2Fdigraph.c
>
> I think digraph.c is a bad example, since some 2000 lines is the of the
> struct defining all those digraphs.
Those lines are in the "not relevant" section. The first line marked
red is 1959:
{
if (backspaced >= 0)
c = getdigraph(backspaced, c, FALSE);
backspaced = -1;
if ((c == K_BS || c == Ctrl_H) && lastchar >= 0)
backspaced = lastchar;
}
This indicates there is no test where 'digraph' is set. That's a nice
exercise :-).
> > I would appreciate it if more tests can be written to increase the
> > coverage, and thus the stability of Vim. The number has been increasing
> > over the past year, but there is still a lot to do.
>
> There is still a patch in the todo list, which includes addional tests:
> ,----
> | Patch to be able to use hex numbers with :digraph. (Lcd, 2015 Sep 6)
> | Update Sep 7. Update by Christian Brabandt, 2015 Sep 8, 2016 Feb 1.
> `----
>
> I think this is the following patch:
> https://github.com/chrisbra/vim-mq-patches/blob/master/digraphs
> (I don't know, if is still applies after the many refactorings in the
> last time)
Sorry about the refactoring breaking patches. I don't plan to do more
of that. At least not at this scale.
Anyway, this has an old style test. Should be easy to turn into a new
style test.
--
Vim is like Emacs without all the typing. (John "Johann" Spetz)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
