Hisashi T Fujioka, Neither build nor test failure do I get with the said patch on my OS X 10.11.5, and the patch itself looks OK for OS X.
So, if you still think the patch is problematic, it might be more helpful if you could add more info to the description of your issue (e.g., build options and error messages), so that someone who suffers a trouble similar to yours can chime in with ease. Best, Kazunobu Kuriyama 2016-07-21 6:46 GMT+09:00 Hisashi T Fujinaka <[email protected]>: > On Wed, 20 Jul 2016, Bram Moolenaar wrote: > > >> Patch 7.4.2079 >> Problem: Netbeans test fails on non-Unix systems. >> Solution: Only do the permission check on Unix systems. >> Files: src/testdir/test_netbeans.vim >> >> >> *** ../vim-7.4.2078/src/testdir/test_netbeans.vim 2016-07-15 >> 17:41:51.650360419 +0200 >> --- src/testdir/test_netbeans.vim 2016-07-19 23:58:46.319716513 >> +0200 >> *************** >> *** 53,60 **** >> func Nb_file_auth(port) >> call assert_fails('nbstart =notexist', 'E660:') >> call writefile(['host=localhost', 'port=' . a:port, 'auth=bunny'], >> 'Xnbauth') >> ! call setfperm('Xnbauth', "rw-r--r--") >> ! call assert_fails('nbstart =Xnbauth', 'E668:') >> call setfperm('Xnbauth', "rw-------") >> exe 'nbstart :localhost:' . a:port . ':bunny' >> call assert_true(has("netbeans_enabled")) >> --- 53,62 ---- >> func Nb_file_auth(port) >> call assert_fails('nbstart =notexist', 'E660:') >> call writefile(['host=localhost', 'port=' . a:port, 'auth=bunny'], >> 'Xnbauth') >> ! if has('unix') >> ! call setfperm('Xnbauth', "rw-r--r--") >> ! call assert_fails('nbstart =Xnbauth', 'E668:') >> ! endif >> call setfperm('Xnbauth', "rw-------") >> exe 'nbstart :localhost:' . a:port . ':bunny' >> call assert_true(has("netbeans_enabled")) >> *** ../vim-7.4.2078/src/version.c 2016-07-19 23:36:24.357635380 >> +0200 >> --- src/version.c 2016-07-20 00:01:39.881914300 +0200 >> *************** >> *** 760,761 **** >> --- 760,763 ---- >> { /* Add new patch number below this line */ >> + /**/ >> + 2079, >> /**/ >> > > I think this is failing on my Mac. Should it even be running this test? > > -- > Hisashi T Fujinaka - [email protected] > BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee > > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- You received this message because you are subscribed to the Google > Groups "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
