Nikolay Pavlov wrote:

> > ***************
> > *** 5131,5136 ****
> > --- 5132,5143 ----
> >       dict_add_nr_str(dict, "width", wp->w_width, NULL);
> >       dict_add_nr_str(dict, "bufnum", wp->w_buffer->b_fnum, NULL);
> >
> > + #ifdef FEAT_QUICKFIX
> 
> This part is not reflected in documentation: if `!has('quickfix')`
> relevant entries are missing, otherwise they are always present. It
> should either always create these numbers (set to zero if
> FEAT_QUICKFIX is not defined) or documentation should explicitly say
> that these keys will be missing in case of `!has('quickfix')`.

I'll add a remark.  There might be more like this.

> I am also not sure whether or not this is needed, but tests do not
> check for `has('quickfix')`.

Well, the test only runs with the +eval feature, which is when normal
features are enabled, and then quickfix is also enabled.  So it would
only fail when someone explicitly disables quickfix.

-- 
How To Keep A Healthy Level Of Insanity:
6. In the memo field of all your checks, write "for sexual favors".

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui