On 21-Aug-2016 23:00, Bram Moolenaar wrote:
John Marriott wrote:
On 21-Aug-2016 02:37, Bram Moolenaar wrote:
Patch 7.4.2231
Problem: ":oldfiles" output is a very long list.
Solution: Add a pattern argument. (Coot, closes #575)
Files: runtime/doc/starting.txt, src/ex_cmds.h, src/eval.c,
src/ex_cmds.c, src/proto/eval.pro, src/proto/ex_cmds.pro,
src/testdir/test_viminfo.vim
After this patch I get the following warning (on mingw64) if
FEAT_QUICKFIX is not defined:
gcc -c -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DFEAT_GUI_W32
-DFEAT_CLIPBOARD -pipe -march=native -Wall -O3 -fomit-frame-pointer
-freg-struct-return -s ex_cmds.c -o gobjnative/ex_cmds.o
ex_cmds.c: In function 'ex_oldfiles':
ex_cmds.c:8415:10: warning: implicit declaration of function
'skip_vimgrep_pat' [-Wimplicit-function-declaration]
if (skip_vimgrep_pat(eap->arg, ®_pat, NULL) == NULL)
^~~~~~~~~~~~~~~~
ex_cmds.c:8415:53: warning: comparison between pointer and integer
if (skip_vimgrep_pat(eap->arg, ®_pat, NULL) == NULL)
^~
I'll move it to a separte #ifdef block. It's unusual that +eval is
included but +quickfix isn't.
After patch 2234 the linker error has gone but the warning remains.
The prototype for skip_vimgrep_pat() lives in quickfix.pro which is
included in proto.h if FEAT_QUICKFIX is defined, but the function itself
is called from ex_cmds.c (above) if either FEAT_EVAL or PROTO are defined.
So, given that skip_vimgrep_pat() has become useful for more than just
the quickfix feature, should it be moved out of quickfix.c altogether
(along with it's prototype)? If so, is there a preference? Perhaps one
of the misc[12].c files?
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
