2016-08-24 2:22 GMT+09:00 Danek Duvall <[email protected]>: > On Tue, Aug 23, 2016 at 06:01:54PM +0900, Kazunobu Kuriyama wrote: > > > Hi Danek, > > > > I think that mismatch is not our fault, either. > > Yeah, that was my thought, but I thought perhaps the Solaris setup was > somehow incorrect. But it really does look like a bug in glib/gtk. I'll > see if I can get a bug filed upstream. > > > That said, it would take some time to file the issue against them and > wait > > for their response to that; it would be better for us to do something > about > > that for ourselves. > > > > So I made a patch for fixing the issue, which is attached to this mail. > > > > For that, I assumed that the Solaris Studio had the predefined constant > > macro __SUNPRO_C. Is that assumption OK? > > Yup, that seems reasonable. And the patch works just fine -- no more > warnings, and the result seems to work just fine. >
Hi Danek, Thanks! Bram, I attached an updated patch to this mail. The previous patch has wrong indentation and superfluous parentheses. The new patch fixes them. > > If that's OK, could you try the patch to check if it works as expected? > > > > Note that the patch includes some minor fixes on coding style, too. > > > > > > > glib is 2.46, gtk3 is 3.18. > > > > > > I don't see this in the travis logs, but I can't tell from there what > > > versions of glib and gtk are in use. > > > > > > Does this look familiar to anyone? > > > > I didn't see either clang or gcc (generic one, not the one which is a > > symbolic link to clang) giving me any warning on the mismatch. I didn't > > know about that until I read you report. > > Yeah; I wonder if gcc would show that with some more -W flags thrown in > there. I thought gcc had such a flag, but I've not found one in the manual yet... > I guess I'm a bit surprised that clang didn't show it; I thought it > did a better job of finding bad code. I guess that's why we try to have a > diverse bundle of compilers. :) > Indeed. And I envy you for the compiler :) > > Thanks, > Danek > Best regards, Kazunobu -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
solaris-studio-gtk3-warning-updated.patch
Description: Binary data
