Hirohito Higashi wrote: > I found a few issues to the display position of the pop-up menu with preview > window. > > 1) Popup menu often drawing over the preview window. > 2) Sometimes, popup menu is displayed in the narrow room side. > > Preparation before reproduction on Linux: > - start terminal emulator (e.g. PuTTY) and set to size 80x24 > - goto vim/src/ directory. > $ cd (yourvimpath)/vim/src > - Prepare test_vimrc. > $ cat test_vimrc > filetype plugin indent on > syntax on > colorscheme desert > set ttm=50 > > > Step to reproduce for case 1: > - Start Vim > $ vim -Nu test_vimrc screen.c > - Type the following command. > :new|wincmd w|norm!2} > - Enter insert mode and start omni completion. > iex_<C-X><C-O> > > Expected behavior: > - Popup menu doesn't drawing over the preview window. > See attached file: case1_expect.png > (We can see the preview window after type <Esc>) > > Actual behavior: > - Popup menu drawing over the preview window. > See attached file: case1_actual.png > > > Step to reproduce for case 2: > - Start Vim > $ vim -Nu test_vimrc screen.c > - Type the following command. > :call feedkeys(":pedit +resize\\ 5\<CR>2}2\<C-E>") > - Enter insert mode and start omni completion. > iex_<C-X><C-O> > > Expected behavior: > - popup menu is displayed in the above (narrow room side). > See attached file: case2_expect.png > > Actual behavior: > - Popup menu is displayed in the below (wide room side). > See attached file: case2_actual.png > > > I wrote a patch. > Please check attached file. > > NOTE: > I removed the following comment. > Because other case always popup menu drawing over the status line. > So my patch follow it. > [popupmnu.c : roughly 90 line] > /* When the preview window is at the bottom stop just above it. > * Also avoid drawing over the status line so that it's clear there > * is a window boundary. */
Thanks. I'll include this. But please watch out for other situations. -- Managers are like cats in a litter box. They instinctively shuffle things around to conceal what they've done. (Scott Adams - The Dilbert principle) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.