Mike Williams wrote:
> On 24/11/2016 20:46, Bram Moolenaar wrote:
> >
> > Patch 8.0.0101
> > Problem: Some options are not strictly checked.
> > Solution: Add flags for strickter checks.
> > Files: src/option.c
> >
> >
> > *** ../vim-8.0.0100/src/option.c 2016-11-24 18:30:55.715444785 +0100
> > --- src/option.c 2016-11-24 21:38:32.823206218 +0100
> > ***************
> > *** 992,998 ****
> > (char_u *)NULL, PV_NONE,
> > #endif
> > {(char_u *)FALSE, (char_u *)0L} SCRIPTID_INIT},
> > ! {"dictionary", "dict", P_STRING|P_EXPAND|P_VI_DEF|P_ONECOMMA|P_NODUP,
> > #ifdef FEAT_INS_EXPAND
> > (char_u *)&p_dict, PV_DICT,
> > #else
> > --- 992,998 ----
> > (char_u *)NULL, PV_NONE,
> > #endif
> > {(char_u *)FALSE, (char_u *)0L} SCRIPTID_INIT},
> > ! {"dictionary", "dict",
> > P_STRING|P_EXPAND|P_VI_DEF|P_ONECOMMA|P_NODUP|P_NFNAME,
> > #ifdef FEAT_INS_EXPAND
> > (char_u *)&p_dict, PV_DICT,
> > #else
>
> This has broken the dictionary option as you can no longer specify a
> filepath -
>
> :set dictionary=a/b
> E474: Invalid argument: dictionary=a/b
>
> Not surprising as P_NFNAME excludes path separators - should it be
> extended to do full filepath validation if not normalisation?
Ah, sorry. The flag name is a bit confusing, as file name normally
means including path separators, but here it really means only the file
name. I think we should add another one for path names.
Should also have a test for this...
--
hundred-and-one symptoms of being an internet addict:
45. You buy a Captain Kirk chair with a built-in keyboard and mouse.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
