Dominique Pellé wrote: > >> >> Vim :profile command was not covered by tests according to coveralls. > >> >> See: > >> >> > >> >> https://coveralls.io/builds/9672985/source?filename=src%2Fex_cmds2.c#L1527 > >> >> > >> >> This pull requests adds test. > >> >> I does not test the ":profdel" command as I did not understand well > >> >> what it does. > >> > > >> > Thanks, I'll include it. > >> > > >> > I wonder why it's so slow. I noticed the started Vim instances never > >> > explicitly exit, but adding :qall! didn't help. > >> > >> Indeed, I now see that running Test_profile_func > >> and Test_profile_file take about 2 sec each. That's > >> unexpectedly slow. > >> > >> Ah, I see! Adding the -es option to Vim makes > >> it almost instantaneous. I also see a that one of the > >> test had an error (l:count should be used instead of count). > >> I notice that by adding call assert_equal(0, v:shell_error) > >> which failed. > >> > >> I suspect that it's also why I had to disable the test on > >> Windows. I'll re-enable the test on Windows to see if > >> it passes on Appveyor all all those fixes. > >> > >> New pull request coming soon... > > > > Looking forward to that. I also noticed a failure on OS/X, where the > > "self" and "total" times happened to be the same. Only one time is > > displayed then. I just sent out a fix for that. > > Pull request https://github.com/vim/vim/pull/1384 > addresses the slow profile tests + other problems. > > But I still had to disable 2 profile tests on Windows > as system(…) fails in Appveyor. I hope that someone > with a Windows box can debug why Test_profile_file > and Test_profile_func fail on Windows.
I managed to try it out. The problem is with the single quotes, on MS-Windows command arguments must be in double quotes. -- Facepalm statement #6: "Estland is a fantasy place, just like Middle Earth and Madagaskar" /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
