Dominique Pellé wrote:
> mch_memmove is typically a #define which
> directly calls memmove(dest, src, len).
>
> But I noticed that in misc2.c, there is an
> implementation for systems that don't
> have memmove(). That implementation is
> wrong! It has its parameters in the wrong
> order. Vim would crash if it was used.
>
> We could fix it as in attached patch, but
> I think that this implementation is actually never
> used anyway and should be removed.
> We could thus replace all mch_memmove() by
> memmove(). memmove() is part of C89. Can't
> we just assume that it's available on all platforms
> where vim is built?
Good catch. So we can assume that this function was never used.
Let's remove it. Might as well keep the other alternatives, they were
at least used at some point in time.
--
DENNIS: Listen -- strange women lying in ponds distributing swords is no
basis for a system of government. Supreme executive power derives
from a mandate from the masses, not from some farcical aquatic
ceremony.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
