Hi Bram! On Sa, 11 Feb 2017, Bram Moolenaar wrote:
> > Christian Brabandt wrote: > > > Bram, > > the latest windows compiled libintl-8.dll from > > https://github.com/mlocati/gettext-iconv-windows adds an additional > > dependency on libgcc_s_sjlj-1.dll for the 32bit architecture. I can > > adjust the vim-win32-installer (see > > https://github.com/vim/vim-win32-installer/pull/20) but the nsis script > > needs to be adjusted as well. So we would need to add the following > > patch to have localization work correctly for 32bit: > > > > diff --git a/nsis/gvim.nsi b/nsis/gvim.nsi > > index 26d7aab8e..74a54333a 100644 > > --- a/nsis/gvim.nsi > > +++ b/nsis/gvim.nsi > > @@ -385,6 +385,7 @@ SectionEnd > > File ${VIMRT}\libintl-8.dll > > File ${VIMRT}\libiconv-2.dll > > File /nonfatal ${VIMRT}\libwinpthread-1.dll > > + File /nonfatal ${VIMRT}\libgcc_s_sjlj-1.dll > > SectionEnd > > !endif > > > > Once this is done, I would go ahead and merge the changes to the > > vim-win32-installer. So that the new installer works correctly. > > > > In return for this added dependency, we could remove the dependency for > > libwinpthread-1.dll, but who knows, if this isn't needed for people self > > compiling their binaries, so I would leave that alone for now. > > > > Thanks to Ken Takata for analyzing and finding this issue. > > Thanks. Should that .dll file then also be included? > If so, where do you get it? That dll is part of the latest release https://github.com/mlocati/gettext-iconv-windows/releases/tag/v0.19.8.1-v1.14 As I said, once I merge vim/vim-win32-installer#20 it will be part of the nightly build (https://github.com/vim/vim-win32-installer/pull/20/commits/85949f1c903da1ebef777c960653139b19b4a14f) Best, Christian -- Man ist in der Liebe darum ungerecht, weil man den andern für vollkommen hielt. -- Jean Paul -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
