On Tue, Feb 28, 2017 at 11:09 AM, Christian Brabandt <[email protected]> wrote: > On Di, 28 Feb 2017, Justin M. Keyes wrote: > >> To further emphasize the case against writable v:shell_error in particular: >> >> https://github.com/tpope/vim-fugitive/issues/648#issuecomment-282515016 >> >> Because the legacy "shell_error" variant (which lacks v: prefix) is >> still supported for "very important" reasons, if it were writable it >> could cause even more subtle bugs for plugin authors. Keeping it >> non-writable guards against those subtle bugs if a plugin author >> accidentally names a local variable "shell_error". > > That is a bug, that would have occurred regardless of v:shell_error
I was referring to the bug in the bug-fix commit, i.e. the accidental usage of the "shell_error" name for a local var. > being writable or not. In fact it is an argument for making the v: > prefix mandatory and break backwards compatibility here. I don't see > this as related to the issue discussed here. If you want to argue for removal of the back-compat that's fine with me, and I agree. It doesn't change the fact that "immutability" helped in this particular case. --- Justin M. Keyes -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
