James McCoy wrote:

> On Tue, Feb 28, 2017 at 10:51:29PM +0100, Bram Moolenaar wrote:
>>
>> Patch 8.0.0389
>> Problem:    Test for arabic does not check what is displayed.
>> Solution:   Improve what is asserted. (Dominique Pelle, closes #1523)
>>             Add a first shaping test.
>> Files:      src/testdir/test_arabic.vim
>>
>>
>> *** ../vim-8.0.0388/src/testdir/test_arabic.vim       2017-02-27 
>> 21:48:06.217790605 +0100
>> --- src/testdir/test_arabic.vim       2017-02-28 22:46:44.550375400 +0100
>> ***************
>> *** 1,21 ****
>>   " Simplistic testing of Arabic mode.
>>
>> ! if !has('arabic')
>>     finish
>>   endif
>>
>> ! set encoding=utf-8
>> ! scriptencoding utf-8
>>
>> ! " Return list of utf8 sequences of each character at line lnum.
>>   " Combining characters are treated as a single item.
>> ! func GetCharsUtf8(lnum)
>>     call cursor(a:lnum, 1)
>>     let chars = []
>>     let numchars = strchars(getline('.'), 1)
>>     for i in range(1, numchars)
>>       exe 'norm ' i . '|'
>> !     call add(chars, execute('norm g8'))
>>     endfor
>>     return chars
>>   endfunc
>> --- 1,23 ----
>>   " Simplistic testing of Arabic mode.
>>
>> ! if !has('arabic') || !has('multi_byte')
>>     finish
>>   endif
>>
>> ! source view_util.vim
>
> Is view_util.vim a new file that was supposed to be committed?

Hi James

It's not a new file.  It's already used in a few tests:

$ cd src/testdir
$ grep view_util.vim  *.vim
test_breakindent.vim:source view_util.vim
test_listlbr_utf8.vim:source view_util.vim
test_listlbr.vim:source view_util.vim
test_number.vim:source view_util.vim

On a different note,  I see that this patch 8.0.0389 has
not been pushed to github yet.

Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui