Kazunobu Kuriyama wrote:

> Attached is a patch to add some tests on the balloon evaluation to test_gui
> in hope of increasing test coverage of gui_eval.c.

Thanks for the tests.

I think we don't need a "Skipped" message for a disabled feature.  We
would get too many of them and won't spot the ones that matter.  We
should only do it if something in the setup is missing, e.g. DISPLAY is
not set.

> As for the GTK3 GUI, the test may issue the following warning:
> 
> (gvim:4161): Gdk-CRITICAL **: gdk_window_get_origin: assertion
> 'GDK_IS_WINDOW (window)' failed
> 
> I looked into all the places in our code where the function is used, and
> once wrapped them with "if (GDK_IS_WINDOW(window))" to avoid passing a
> wrong argument to the function, but still got the same warning.  Meanwhile,
> there was no crash or apparent glitches.  So I conclude for now that it
> comes from the GTK3 internal, and that it is not that critical, as is often
> the case with that toolkit.
> 
> That said, if you find anything more than the warning, please let me know.

I have seen those errors often.  But never a crash.

-- 
hundred-and-one symptoms of being an internet addict:
51. You put a pillow case over your laptop so your lover doesn't see it while
    you are pretending to catch your breath.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui