Hi Daniel,
On Wed, May 3, 2017 at 10:03 AM, Daniel Hahler
<[email protected]> wrote:
> I've found an issue where Vim might use a re-cycled buffer for a quickfix
> entry, that should not be used.
>
> I could not create a more simple test case that worked reliably, but it is
> caused by using bwipe and new, where the buffer before the wiping gets the
> same %d representation (through fprintf(stderr, "buf: %d\n")).
>
> The following is a Vader test, but should work in general - except for that
> it might not trigger it.
> I have noticed that even adding a new line between bwipe and new might
> change it..
>
> Also commenting the free_buffer in close_buffer, or rather the vim_free(buf)
> at the end works around it.
> It seems like without it the new buffer will (more likely) get the same
> address as the previous one, where qf_last_bufref.br_buf points at then
> still?!
>
>
I am able to reproduce this problem using the commands you have listed
in your last e-mail.
>
> A fix, but it might also have to compare b_ffname, and in the end
> qf_last_bufname/qf_last_bufref should be handled instead when a buffer is
> wiped?!
>
I am not sure whether this is the right fix. We should wait for comments
from Bram.
- Yegappan
> diff --git c/src/quickfix.c i/src/quickfix.c
> index 7b07f9358..91f5259fd 100644
> --- c/src/quickfix.c
> +++ i/src/quickfix.c
> @@ -1713,7 +1713,9 @@ qf_get_fnum(qf_info_T *qi, char_u *directory, char_u
> *fname)
> bufname = fname;
>
> if (qf_last_bufname != NULL && STRCMP(bufname, qf_last_bufname) == 0
> - && bufref_valid(&qf_last_bufref))
> + && bufref_valid(&qf_last_bufref)
> + && qf_last_bufref.br_buf->b_sfname
> + && STRCMP(qf_last_bufref.br_buf->b_sfname, bufname) == 0)
> {
> buf = qf_last_bufref.br_buf;
> vim_free(ptr);
>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
