2017-05-06 4:44 GMT+09:00 Bram Moolenaar <[email protected]>: > > Kazunobu Kuriyama wrote: > > > When the GTK+ 1 code was removed by the commit 182c5be11 on 2010-06-25, > the > > minimum required version for the GTK+ 2 GUI was set to 2.2 > > (src/configure.ac:2595--2598). > > > > In spite of that change, the condition on when HAVE_GTK_MULTIHEAD is > > defined was left unchanged (src/configure.ac:2608--2609), and it has > long > > been the inequality GTK+ >= 2.1.1. > > > > Accordingly, for the current build system since then, HAVE_GTK_MULTIHEAD > is > > always defined for any GTK+ GUI builds, and thus obviously redundant. > > > > With the attached patch, I propose to remove the else blocks of "#ifdef > > HAVE_GTK_MULTIHEAD" , those #ifdef's, and the macro itself from the > > codebase to make the code relevant to the macro neater and consistent. > > Thanks! > > I currently have very little time to work on Vim, I'll put it on the > todo list. >
An updated patch is attached. It fixes a mistake in style of my previous patch: In the hunk about create_blank_pointer(), a block of C code was mistakenly shifted to left. Probably, I did that when I reduced the depth of nesting of the preprocessor statements surrounding the block. Kazunobu > > -- > BRIDGEKEEPER: What is the air-speed velocity of an unladen swallow? > ARTHUR: What do you mean? An African or European swallow? > BRIDGEKEEPER: Er ... I don't know that ... Aaaaarrrrrrggghhh! > BRIDGEKEEPER is cast into the gorge. > "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES > LTD > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ > \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
remove_HAVE_GTK_MULTIHEAD-update01.patch
Description: Binary data
