On Do, 14 Sep 2017, Tony Mechelynck wrote:
> "Subscript is above array bounds", see below; In Huge build with
> +terminal, not in Tiny build with -terminal.
>
> On Thu, Sep 14, 2017 at 12:01 AM, Bram Moolenaar <[email protected]> wrote:
> >
> > Patch 8.0.1102
> > Problem: Terminal window does not use Normal colors.
> > Solution: For the GUI and when 'termguicolors' is enabled, use the actual
> > foreground and background colors for the terminal. (Yasuhiro
> > Matsumoto, closes #2067)
> > Use the "Terminal" highlight group if defined.
> > Files: src/terminal.c, src/syntax.c, src/proto/syntax.pro
>
> gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -pthread
> -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include
> -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libpng16
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16
> -I/usr/include/pango-1.0 -I/usr/include/harfbuzz
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
> -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -D_REENTRANT
> -DORBIT2=1 -pthread -I/usr/include/libgnomeui-2.0
> -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0
> -I/usr/include/libxml2 -I/usr/include/libgnome-2.0
> -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0
> -I/usr/include/orbit-2.0 -I/usr/include/libgnomecanvas-2.0
> -I/usr/include/gail-1.0 -I/usr/include/libart-2.0
> -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include
> -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libpng16
> -I/usr/include/pango-1.0 -I/usr/include/harfbuzz
> -I/usr/include/pango-1.0 -I/usr/include/freetype2
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16
> -I/usr/include/gnome-vfs-2.0 -I/usr/lib64/gnome-vfs-2.0/include
> -I/usr/include/gconf/2 -I/usr/include/dbus-1.0
> -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/lib64/glib-2.0/include -O2 -fno-strength-reduce -Wall
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/terminal.o
> terminal.c
> terminal.c: In function ‘cterm_color2rgb’:
> terminal.c:2440:24: warning: array subscript is above array bounds
> [-Warray-bounds]
> rgb->blue = grey_ramp[nr];
relevant part of the patch:
+ else if (nr < 256)
+ {
+ /* 24 grey scale ramp */
+ idx = nr - 232;
+ rgb->blue = grey_ramp[nr];
+ rgb->green = grey_ramp[nr];
+ rgb->red = grey_ramp[nr];
This needs to use idx as index and not nr. See also #2086.
Best,
Christian
--
Wer kann sagen, er erfahre was, wenn er nicht ein Erfahrender
ist?
-- Goethe, Maximen und Reflektionen, Nr. 679
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
