On Wed, Oct 4, 2017 at 5:55 AM, Manuel Ortega <[email protected]> wrote:
> On Tue, Oct 3, 2017 at 10:29 PM, Ben Fritz <[email protected]> wrote:
>>
>> On Monday, October 2, 2017 at 1:05:03 PM UTC-5, Bram Moolenaar wrote:
>> > Christian wrote:
>> >
>> > > Bram,
>> > > since Vim can now display strikethrough attributes (in the gui), let's
>> > > make a bit more use of it.
>> > >
>> > > This patch adds the strikethrough attribute to the diff syntax file
>> > > for
>> > > deleted lines. Since this impacts readability, put the change behind a
>> > > switch and document is properly.
>> > >
>> > > For an example see the attached screenshot.
>> >
>> > I can't say I like it, I would not use it.  But perhaps someone does.
>> >
>> > Is setting a variable simpler than letting the user define his own
>> > highlight?  Well, I suppose that might not work well when switching
>> > colorschemes.  And your trick to copy the attributes from "Special"
>> > isn't something I would advertise...
>> >
>>
>> I for one will definitely use it, I didn't remember that strikethrough had
>> been added! Thanks for the example, if nothing else!
>
>
> Am I the only one who looked at the screenshot and found it harder to read
> than the non-strikethough version of diff highlighting?  Seriously, the
> *color* is what tells the reader which text is the old text.  A big
> strikethough does nothing but partially obscure the changed text, which
> makes it harder to read and is a bad thing. The problem might even be
> sometimes more acute than that.  Maybe one's font has a dotted zero to
> distinguish it from 'O'; if the strikethrough obscures the dot in the zero,
> then one won't be able to easily tell whether the old character was zero or
> 'O'.
>
> Anyway, if this suggestion gets adopted, I sure hope there will be some easy
> way for the user to turn it off, rather than manually performing surgery on
> every installed colorscheme, or setting up a hacky autocmd.
>
> (As a general point, there really needs to be in Vim an easy way to get rid
> of, say, all the "{,c}term=bold" or "gui=underline" in a single built-in ex
> command.  Something like ":hi clearattribute term bold"  Were there such a
> mechanism, it would also easily allow the user to avoid the problem of
> strikethrough making diff text less readable.)
>
> -Manny

That's why Christian put it behind a switch, with default "unchanged
from previous versions" (i.e. off):
• You want removed lines striked through? :let diff_use_strikethrough = 1
• You don't? Do nothing.

Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui