Michael Soyka wrote:

> Vim Developers:
> 
> In the file src/Make_cyg_ming.mak, the variable ICONV is given the value 
> "yes" on line 51, suggesting it is intended to be boolean valued.  It is 
> tested as a boolean on line 847 but is also used, I believe incorrectly, 
> on lines 848 and 849:
> 
> 847 ifneq (yes, $(ICONV))
> 848 LIB += -L$(ICONV)
> 849 CFLAGS += -I$(ICONV)
> 850 endif
> 
> I don't know what the correct value should be on lines 848 and 849 but 
> I'm pretty sure it isn't "yes" or "no".  I'll leave that decision to 
> someone who knows the answer!

Looks OK to me:

        ifdef ICONV
        ifneq (yes, $(ICONV))
        LIB += -L$(ICONV)
        CFLAGS += -I$(ICONV)
        endif
        DEFINES+=-DDYNAMIC_ICONV
        endif

If you set ICONV to "yes" then no -L or -I argument is added.

However, the similar GETTEXT has a problem.  Like ICONV it has this
section:

        ifdef GETTEXT
        ifneq (yes, $(GETTEXT))
        CFLAGS += -I$(GETTEXTINCLUDE)
        ifndef STATIC_GETTEXT
        LIB += -L$(GETTEXTLIB) -l$(INTLLIB)
        ifeq (USE_SAFE_GETTEXT_DLL, $(DYNAMIC_GETTEXT))
        OBJ+=$(SAFE_GETTEXT_DLL_OBJ)
        endif
        else
        LIB += -L$(GETTEXTLIB) -lintl
        endif
        endif
        endif

However, setting GETTEXT to "yes" will do weird things here:

        SAFE_GETTEXT_DLL_OBJ = 
$(GETTEXT)/src/safe_gettext_dll/safe_gettext_dll.o

        INTLPATH=$(GETTEXT)/lib/mingw32

        ifdef GETTEXT
        DEFINES += -DHAVE_GETTEXT -DHAVE_LOCALE_H
        GETTEXTINCLUDE = $(GETTEXT)/include
        GETTEXTLIB = $(INTLPATH)
        ifeq (yes, $(GETTEXT))
        DEFINES += -DDYNAMIC_GETTEXT
        else

I hope someone can clear that up.

-- 
Facepalm reply #3: "I had a great time in Manhattan" "I thought you were
going to New York?"

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui