Joseph Dornisch wrote:
> I tried the nightly build and have had the same crash - and I know its
> winminheight=0 as I had been operating for around a month with no
> crashes when I have it set to one. So somewhere, vim is using this
> number as a devisor - where it didn't use to (up until at least
> vim7.3.x.
> Anyhow, I still haven't managed to compile Vim, but I will give it
> another shot (probably next week). I doubt the dump was very useful,
> but I did look at the code, and while I am not fluent in the code my
> guess is that the error is caused in window.c::set_fraction
> void
> set_fraction(win_T *wp)
> {
> wp->w_fraction = ((long)wp->w_wrow * FRACTION_MULT
> + wp->w_height / 2) / (long)wp->w_height;
> }
>
> It seems like a good guess since I like to have winminheight set to 0
> and thats when I see the crashes. I would note that there is at least
> one spot where w_height is checked to be greater than 0 (in
> win_split).
Good point. The function assumes that the caller has checked the window
height is not zero, but perhaps there are corner cases when that's not
true. Let's change the function to only set the fraction if the window
is at least two lines. It doesn't make sense for one line windows and
would crash with zero line windows.
--
How To Keep A Healthy Level Of Insanity:
10. Ask people what sex they are. Laugh hysterically after they answer.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
