John Marriott wrote: > On 26-Nov-2017 01:20, Bram Moolenaar wrote: > > Patch 8.0.1336 > > Problem: Cannot use imactivatefunc() unless compiled with +xim. > > Solution: Allow using imactivatefunc() when not compiled with +xim. > > (Yasuhiro Matsumoto, closes #2349) > > Files: runtime/doc/options.txt, runtime/doc/mbyte.txt, src/mbyte.c, > > src/option.c, src/option.h, src/structs.h, > > src/testdir/test_iminsert.vim, src/Makefile, > > src/testdir/Make_all.mak, src/vim.h > > > > > After the patch series that deals with imactivatefunc (starting with > 1336), I get a build failure on HP-UX if FEAT_MBYTE is disabled, like so: > cc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -o objects/mbyte.o > mbyte.c > cc: "mbyte.c", line 4803: error 1588: "p_imaf" undefined. > cc: "mbyte.c", line 4803: warning 563: Argument #1 is not the correct type. > cc: "mbyte.c", line 4803: warning 527: Integral value implicitly > converted to pointer in assignment. > cc: "mbyte.c", line 4803: warning 563: Argument #2 is not the correct type. > cc: "mbyte.c", line 4803: warning 526: Pointer implicitly converted to > integral value in assignment. > cc: "mbyte.c", line 4803: warning 563: Argument #3 is not the correct type. > cc: "mbyte.c", line 4821: error 1588: "p_imsf" undefined. > cc: "mbyte.c", line 4821: warning 563: Argument #1 is not the correct type. > cc: "mbyte.c", line 6490: error 1588: "p_imsf" undefined. > cc: "mbyte.c", line 6490: error 1554: Indirection must be through a pointer. > cc: "mbyte.c", line 6490: error 1563: Expression in if must be scalar. > *** Error exit code 1 > > Stop. > *** Error exit code 1 > > Stop. > > The variable "p_imaf" is declared in option.h only if FEAT_EVAL and > FEAT_MBYTE are defined, but mbyte.c (line 4786 et al) references it > without checking them both. I have prepared a patch that attempts to fix > it, please check.
I suppose this happens when FEAT_EVAL is defined but FEAT_MBYTE is not. It's confusing to have non-mbyte stuff inside mbyte.c... I think when FEAT_XIM is defined this implies FEAT_MBYTE, so not all of your changes are required. Hmm, actually, it's possible to have XIM while MBYTE is not defined. I think that's wrong, I see no good reason to support input methods with single byte encodings. -- Latest survey shows that 3 out of 4 people make up 75% of the world's population. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
