Micah Bucy wrote:
> So I've been debugging a build issue against python3. Specifically changes
> made by https://www.python.org/dev/peps/pep-0539/
>
> https://github.com/vim/vim/blob/master/src/if_python3.c lines 38-40 appear to
> be the culprit.
>
> It's weird but it appears as if once _POSIX_THREADS has been undefined, it
> can not be defined again. I even included unistd.h manually afterwards to
> test. I'm wondering if perhaps unistd.h is being included earlier in the
> stack, so it gets detected as a duplicate and never gets included again thus
> _POSIX_THREADS remains in an undef state.
>
> Is there a specific reason for the undef in the first place? Based on the
> comment on line 37, it doesn't appear to be necessary.
>
> I'm building on macOS using Apple LLVM version 9.1.0 (clang-902.0.31). I also
> tried with gcc version 7.3.0 (Homebrew GCC 7.3.0) in case it was a compiler
> issue.
I assume this was done because an older Python.h was defining
_POSIX_THREADS unconditionally, causing a warning during compilation.
We could try removing these lines and see if someone has a problem with
it.
It's probably not a good idea to undefine _POSIX_THREADS in only one
source file anyway.
--
Sometimes you can protect millions of dollars in your budget simply by buying
a bag of cookies, dropping it on the budget anylyst's desk, and saying
something deeply personal such as "How was your weekend, big guy?"
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.