2018-03-24 14:02 GMT+01:00 Bram Moolenaar <[email protected]>: > > Antoine wrote: > >> @brammool , first my mistake, ```g:terminal_color_``` are actually set by >> ``gruvbox`` (my colorscheme plugin). >> >> Then here is the minimal .vimrc to reproduce the different behaviors: >> ```vim >> call plug#begin('~/.vim/plugins_by_vimplug') >> Plug 'morhetz/gruvbox' >> call plug#end() >> >> set termguicolors >> colorscheme gruvbox >> ``` >> >> I used gnome-terminal on Ubuntu 16.04. >> Here is what ```ls --color=auto``` looks on vim: >> >>  >> Here is what ```ls --color=auto``` looks on neovim: >> >>  >> >> Maybe setting extra variable is not the right approach, but if it is, >> would it be possible to keep the same naming convention as in neovim ? > > As mentioned in the other message, using global variables looks like a > bad choice.
The global variables are indeed a hack. I suggest instead highlight group names like TermColor1, TermColor2, for each of the color indices. >> More and more features are slightly different between vim and neovim >> (terminal, jobs etc) and it makes it harder and harder for users and >> plug-in developers to support both editors. > > Neovim is a fork, thus they should follow Vim, if they so desire. > They made their own design choices and haven't discussed them on > vim-dev, so it's no surprise diversion happens. Neovim project did try to follow Vim's own conventions. For example, names of job*() functions were chosen in analogy with buf*() functions, observing that the old buffer_exists(), buffer_name(), etc. were deprecated. But then Vim decided to add underscores again for no apparent reason. Not to mention, Vim's jobs API is arbitrarily different, it isn't meaningfully different, so it is incompatible merely on a whim with conventions that had already been established 2 years earlier by Nvim. The name of TermOpen was discussed in: https://groups.google.com/d/msg/vim_dev/c5uBCS-_QyI/S15G3mG5AgAJ where Nikolai cited evidence that there's no consistent choice of "term" or "terminal". But you ignored the discussion, and named the event TerminalOpen, anyway, which again adds entropy for no reason. --- Justin M. Keyes -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
