On Do, 24 Mai 2018, h_east wrote:

> Hi,
> 
> 2018-5-24(Thu) 17:29:20 UTC+9 Christian Brabandt:
> > Hm, it looks like BalloonEval is initially not set therefore skipping 
> > displaying the balloon.
> > 
> > Shouldn't we need something like this?
> > 
> > diff --git a/src/evalfunc.c b/src/evalfunc.c
> > index 2793803b7..a1e243a9e 100644
> > --- a/src/evalfunc.c
> > +++ b/src/evalfunc.c
> > @@ -1481,6 +1481,8 @@ f_atan2(typval_T *argvars, typval_T *rettv)
> >      static void
> >  f_balloon_show(typval_T *argvars, typval_T *rettv UNUSED)
> >  {
> > +    if (balloonEval == NULL)
> > +       balloonEval = (BalloonEval *)alloc(sizeof(BalloonEval));
> >      if (balloonEval != NULL)
> >      {
> >         if (argvars[0].v_type == VAR_LIST
> 
> Probably not a bug.
> You should turn on 'ballooneval' option.
> I think that it is better to mention 'ballooneval' in the document of 
> balloon_show().

That is already mentioned. However even when ballooneval is set, the 
balloonEval struct is not properly allocated and no balloon is being 
shown, e.g.
#v+
vim --clean -c ':set ballooneval balloonevalterm' -c 'call balloon_show("The 
Balloon")'
#v-

doesn't work. Okay, perhaps BalloonEval struct should be allocated when 
setting ballooneval and balloonevalterm option. But on the other hand, I 
like it that balloon_show does not check the ballooneval option.

Best,
Christian
-- 
Daimler Benz ist es nun gelungen, für eine Entwicklungssumme von über
einer Milliarde DM ein Auto zu entwickeln, welches sich bei Gefahr auf
den Rücken legt und tot stellt.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui