Jason Franklin wrote:
> I was a little confused by this patch, and I was hoping you'd enlighten me. > > 1. I see that the error messages from the test don't show up when I restored > 'modifiable' in the original patch. So I didn't see them while working. > > 2. They also go away when using ":setlocal" instead of ":set", as you did. > > This seems weird to me, and I'm not exactly sure why this works. Since > 'modifiable' is always local to the buffer, shouldn't ":set" work just as > well? I'm just having trouble making sense of your commit message. > > I'm puzzled. What happened is that I removed restoring 'modified', ran the tests and it looked OK. But then CI failed. But without an actual error message. I then figured that what happens is that because 'modified' is off in testdir/messages, the test script is unable to tell us what went wrong. The obvious mistake was to use "set" instead of "setlocal". Your original change worked around that be resetting 'modified', which also resets the global (default) value. This is the value picked up by new buffers, thus the global value for the local option. -- Why is it called "Windows"? "Gates" would be more appropriate... /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
