Dominique wrote:
> Marius Gedminas <[email protected]> wrote: > > > On Tue, Nov 24, 2015 at 05:11:02PM +0100, Bram Moolenaar wrote: > > > Dominique wrote: > > > > > > > afl-fuzz fuzzer came up with the following command, > > > > which causes access to uninitialized memory in > > > > Vim-7-4-909: > > > > > > > > $ valgrind --track-origins=yes 2> valgrind.log \ > > > > vim -u NONE -c 'syn keyword x nextgroup=\(\1\)' > > > > > > > > In valgrind.log: > > > > > > > > ==4366== Memcheck, a memory error detector > > > > ==4366== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. > > > > ==4366== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for > > > > copyright info > > > > ==4366== Command: ./vim -u NONE -c syn\ keyword\ x\ nextgroup=\\(\\1\\) > > > > ==4366== > > > > ==4366== Conditional jump or move depends on uninitialised value(s) > [...] > > > > > > Is this fixed by patch 7.4.937, or is this another problem? > > > > I can reproduce this with vim 7.4.941, so it must be a different > > problem. > > > > (Unsurprisingly, since \z(\) doesn't make an appearance.) > > Replying to this old thread. > I just tried to reproduce this with the latest Vim-8.1.177 > and I cannot reproduce it anymore. > > Doing a git bissection, the issue was resolved in this > commit more than a year ago: > > === > commit 1ef9bbe215e13a273e74fccaddd8fc5a42c76b6e > Author: Bram Moolenaar <[email protected]> > Date: Sat Jun 17 20:08:20 2017 +0200 > > patch 8.0.0645: no error for illegal back reference in NFA engine > > Problem: The new regexp engine does not give an error for using a back > reference where it is not allowed. (Dominique Pelle) > Solution: Check the back reference like the old engine. (closes #1774) > === > > So we can remove this item still in runtime/doc/todo.txt as > in attached patch: > > === > Access to uninitialized memory in match_backref() regexp_nda.c:4882 > (Dominique Pelle, 2015 Nov 6) > === Thanks. Also took care of the other one. Perhaps some day the todo list will actually get shorter :-). -- hundred-and-one symptoms of being an internet addict: 231. You sprinkle Carpet Fresh on the rugs and put your vacuum cleaner in the front doorway permanently so it always looks like you are actually attempting to do something about that mess that has amassed since you discovered the Internet. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
