Christian Brabandt <[email protected]> wrote: > On Di, 17 Jul 2018, Dominique Pellé wrote: > > > Bram Moolenaar <[email protected]> wrote: > > > > > Patch 8.1.0193 > > > Problem: Terminal debugger buttons don't always work. (Dominique Pelle) > > > Solution: Set 'cpo' to its default value. > > > Files: runtime/pack/dist/opt/termdebug/plugin/termdebug.vim > > > > Unfortunately, I still see the same issue after 8.1.193. > > I don't have the time right now to look further, but I can debug later > > this week. > > > > I suspect that the "\r" substitution happens when executing the command > > rather than when defining the command. > > Yeah, by the time the :commands are defined, the 'cpo' setting has > already been restored to the old user setting. > > It basically comes down to this test here: > > function! Test_CPO() > let _cpo=&cpo > set cpo= > com! Continue :echo "Conteinue\r" > com Continue > set cpo=B > com! Continue :echo "Conteinue\r" > com Continue > let &cpo=_cpo > endfunction > call Test_CPO() > > So I think we need in addition: > > diff --git a/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim > b/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim > index 4ccbc4cb6..d47de3616 100644 > --- a/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim > +++ b/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim > @@ -566,6 +566,9 @@ endfunc > > " Install commands in the current window to control the debugger. > func s:InstallCommands() > + let _cpo = &cpo > + set cpo&vim > + > command Break call s:SetBreakpoint() > command Clear call s:ClearBreakpoint() > command Step call s:SendCommand('-exec-step') > @@ -603,6 +606,7 @@ func s:InstallCommands() > an 1.230 PopUp.Evaluate :Evaluate<CR> > endif > endif > + let &cpo=_cpo > endfunc > > let s:winbar_winids = []
Thanks Christian. Just to confirm that your patch fixes it. Dominique -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
