Jason Franklin wrote:

> I noticed when tab-completing shell commands (e.g., ":Man <TAB>" or ":!
> <TAB>") that sub-directories of directories in my $PATH were included in
> the results.  To me this was undesirable.  I can't think of why this
> would be useful... please correct me if I'm wrong.
> 
> The patch below fixes this problem by making the flags used to expand
> shell commands constant (so that directories are not included).  Please
> note that if this is included, it may be advisable to get rid of the
> "flagsarg" argument to "expand_shellcmd()" as it would no longer serve
> any purpose.
> 
> Also, I'm trying to submit patches properly... I think I'm doing it right
> (I start at the "---") with the patch right?  Still working on my email
> workflow.

Hmm, there is indeed something wrong.  Subdirectories should only be
expanded for the current directory, ":!dir/cmd" should execute
./dir/cmd. Expanding a directory in an item in $PATH doesn't make sense,
since when the name contains a slash then $PATH is not used.

I don't think your patch is the solution though.

-- 
Two fish in a tank. One says to the other:
"Do you know how to drive this thing?"

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui