Hi
cppcheck static analyzer gives this warning:
[/home/pel/sb/vim/src/memline.c:5032]: (style) Array index 'curix' is
used before limits check.
It's hard to tell whether it can cause an
invalid memory access in practice, but it
is safer to swap the conditions in the 'if' as
in attached patch.
Regards
Dominique
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/memline.c b/src/memline.c
index 9789349fa..fca69dfef 100644
--- a/src/memline.c
+++ b/src/memline.c
@@ -5029,8 +5029,8 @@ ml_updatechunk(
curline += buf->b_ml.ml_chunksize[curix].mlcs_numlines;
}
}
- else if (line >= curline + buf->b_ml.ml_chunksize[curix].mlcs_numlines
- && curix < buf->b_ml.ml_usedchunks - 1)
+ else if (curix < buf->b_ml.ml_usedchunks - 1
+ && line >= curline + buf->b_ml.ml_chunksize[curix].mlcs_numlines)
{
/* Adjust cached curix & curline */
curline += buf->b_ml.ml_chunksize[curix].mlcs_numlines;
