On Sat, Dec 22, 2018 at 2:54 PM Bram Moolenaar <[email protected]> wrote:
>
>
> Gary Johnson wrote:
>
> > On 2018-12-22, Tony Mechelynck wrote:
> > > Setting $CONF_ARGS in the environment doesn't work anymore: it is
> > > overridden (unless make is called with the -e switch, which is not
> > > normal practice) by the line
> > >
> > > CONF_ARGS = $(CONF_ARGS1) $(CONF_ARGS2) $(CONF_ARGS3) $(CONF_ARGS4)
> > > $(CONF_ARGS5)
> > >
> > > at line 326 of src/Makefile. Setting $CONF_ARGS1 to $CONF_ARGS5 works,
> > > since lines 321-325 of the same Makefile are commented-out.
> > >
> > > So if e.g. you had
> > >
> > > export CONF_ARGS='--with-vim-name=vi'
> > >
> > > in the bash startup script in your shadow directory for building a
> > > Tiny Vim, that line must now be replaced by
> > >
> > > export CONF_ARGS2='--with-vim-name=vi'
> > >
> > > otherwise your Tiny Vim will be built with the executable name "vim",
> > > and "make installvimbin" will copy and strip it into
> > > /usr/local/bin/vim, which is not what you want.
> > >
> > > N.B. I don't edit the src/shadow-*/Makefile or the src/Makefile;
> > > instead, I create soft links Makefile -> ../Makefile in each shadow
> > > directory and set my configure arguments by means of environment
> > > variables. This way I always use the latest Makefile. But I have to
> > > keep watch for incompatible changes like the one above.
>
> Sorry about that, I thought values passed in would override values set
> in the Makefile.
Values passed-in as environment variables _only_ override values set
in the Makefile if make is invoked as "make -e" (as I do when creating
shadow-directories, e.g. "SHADOWDIR='shadow-small' make -e shadow", to
override the "SHADOWDIR=shadow" set in the Makefile).
>
> > That's a good short-term work-around, but wouldn't it be better to
> > fix the problem by replacing that CONF_ARGS assignment in
> > src/Makefile with this:
> >
> > CONF_ARGS = $(CONF_ARGS) $(CONF_ARGS1) $(CONF_ARGS2) $(CONF_ARGS3)
> > $(CONF_ARGS4) $(CONF_ARGS5)
>
> That doesn't work, my Make complains about a recursive value.
> Let me comment-out that line, that should work. And still avoid the
> confusion when someone un-comments more then one CONF_ARGS line.
IIUC, this returns to what it used to be. Maybe I'll have to set both
$CONF_ARGS and $CONF_ARGS2 now.
I suggest, instead of commenting the line, to replace it with
ifndef CONF_ARGS
CONF_ARGS = $(CONF_ARGS1) $(CONF_ARGS2) $(CONF_ARGS3)
$(CONF_ARGS4) $(CONF_ARGS5)
endif
which will construct $CONF_ARGS by concatenation if and only if it
hasn't yet been set.
Best regards,
Tony.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
