On Fri, Feb 8, 2019, 11:00 Bram Moolenaar <[email protected] wrote: > > Ozaki Kiichi wrote: > > > It need remove the following. > > > > --- a/src/testdir/test_functions.vim > > +++ b/src/testdir/test_functions.vim > > @@ -1237,7 +1237,6 @@ func Test_platform_name() > > if has('unix') && executable('uname') > > let uname = system('uname') > > call assert_equal(uname =~? 'BeOS', has('beos')) > > - call assert_equal(uname =~? 'BSD\|DragonFly', has('bsd')) > > " GNU userland on BSD kernels (e.g., GNU/kFreeBSD) don't have BSD > defined > > call assert_equal(uname =~? '\%(GNU/k\w\+\)\@<!BSD\|DragonFly', > has('bsd')) > > call assert_equal(uname =~? 'HP-UX', has('hpux')) > > What is your "uname" output then? >
Your patch added my comment and a new test, whereas my patch added a comment and fixed the regex for the existing test. Ozaki's pointing out that you forgot to remove the original line. These sorts of problems would be avoided if the PRs were actually merged, instead of whatever process you use instead. Cheers, James > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
