Ken Takata wrote:

> 2019/2/18 Mon 9:12:03 UTC+9 h_east wrote:
> > Hi,
> > 
> > 2019-2-18(Mon) 8:46:17 UTC+9 Heptite:
> > > On Sun, 17 Feb 2019, Cesar Romani wrote:
> > > 
> > > > if_ruby.c:68:11: fatal error: dlfcn.h: No such file or directory
> > > > # include <dlfcn.h>
> > > >           ^~~~~~~~~
> > > > compilation terminated.
> > > > make: *** [gobjZi686/if_ruby.o] Error 1
> > > > Error by compiling gvim.exe
> > > 
> > > I tracked this down to MSWIN not being defined before it is tested 
> > > for. (MSWIN being defined in vim.h.)
> > > 
> > > I was able to get that one file to compile by adding a -DMSWIN on the 
> > > command line, but that's just a workaround.
> > 
> > Please check with the attached patch.
> > Thank you for reporting.
> 
> > +#if !(defined(WIN32) || defined(_WIN64))
> 
> I think this line can be simpler:
> 
>  #ifndef WIN32
> 
> Moreover, indentation is incorrect around this line.
> I attached a patch to fix both of them.

Can we move including vim.h to the start of the file?
Then we can also drop some other includes, such as "auto/config.h".

Would need to try it out, and possibly move things that really need to happen
before including vim.h to above that.

-- 
At some point in the project somebody will start whining about the need to
determine the project "requirements".  This involves interviewing people who
don't know what they want but, curiously, know exactly when they need it.
                                (Scott Adams - The Dilbert principle)

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui