On Mi, 20 Mär 2019, Bram Moolenaar wrote:
> > > the latest build of the vim-win32-installer failed with this error > > message: > > > > https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/23206196/job/2i61rw80gx51ubv7#L6622 > > > > function RunTheTest[40]..Test_memory_func_capture_lvars line 29: > > Expected range 23092 - 43324, but got 22800 > > > > It is kind of strange, that the test fails, because Vim uses less memory > > than expected. So I wonder, if this patch would make a difference: > > When I run it the "min" value is zero, thus that doesn't work well. Yeah you are right, min can never be larger than zero. I think the test is wrong and we need this: diff --git a/src/testdir/test_memory_usage.vim b/src/testdir/test_memory_usage.vim index 23dcc62ac..62607a6f9 100644 --- a/src/testdir/test_memory_usage.vim +++ b/src/testdir/test_memory_usage.vim @@ -36,7 +36,7 @@ func s:monitor_memory_usage(pid) abort let proc = {} let proc.pid = a:pid let proc.hist = [] - let proc.min = 0 + let proc.min = 99999999 let proc.max = 0 > For me the "last" value is also very close to "before.last". > Let's use 80% of the "before.last" value. It still fails for line 24 of Test_memory_func_capture_vargs() which is this one: ,---- | " In this case, garbase collecting is not needed. | call assert_equal(after.last, after.max) `---- Perhaps this should be skipped for Windows x86? Or at least be set to be flaky? https://ci.appveyor.com/project/chrisbra/vim-win32-installer/build/job/ph4jsqdjrpvil27t (this is the x86 build, not the 64 bit build.) Can anybody here that builds Vim on Windows reproduce the problem with this test on Windows? Best, Christian -- Uneigennützige Freundschaft gibt es nur unter Leuten gleicher Einkommensklasse. -- Jean-Paul Getty -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
