On Tue, Apr 23, 2019 at 11:48 AM Dominique Pellé <[email protected]> wrote: > > Christian Brabandt <[email protected]> wrote: > > > On Di, 23 Apr 2019, tooth pik wrote: > > > > > is "make test" supposed to work currently? i can't remember the last > > > time i didn't > > > get a failed somethingorother from it > > > > > > this time it's errors in Test_incsearch_substitute_dump() > > > > > > i don't run make test very often so I'm curious -- are tests supposed > > > to succeed? > > > > Yes the test suite is supposed to be comleted successfully and I don't > > remember a breakage for a longer time (exceptions being new patches > > temporarily breaking it, but those problems have been fixed very soon by > > Bram). > > > > If you encounter a failing test, please show the log of it. > > Is that really true? I always build Vim in parallel > with "make -j8" but I never run tests in parallel. It > would certainly be nice if tests could be run in > parallel, but at the moment it does not seem safe. > > Here for example I see 2 tests writing the same file > name "Xtest1" which prevents running tests safely > in parallel. I'm almost sure that there are other cases > like this: > > $ cd vim/src > $ grep "writefile(.*'Xtest1'" *.vim > test_swap.vim: call writefile(content, 'Xtest1') > test_winbuf_close.vim: call writefile(['testtext 1'], 'Xtest1') > > Dominique > Maybe the tests should write, not files with generic names like "Xtest1" but files with names related to the test name, e.g., Xswap1, Xwinbuf_close1, etc.?
Best regards, Tony. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
