Hi,
2019/5/14 Tue 5:58:30 UTC+9 Jason Franklin wrote:
> Bram,
>
> Thank you so much for taking the time to work with me on this.
>
> Unfortunately, I still can't get the colors to match on the latest build
> (patch 8.1.1330). I should note that the color scheme is much closer than it
> was before, but it looks like some of the colors are being modified when
> displayed in the Vim terminal window. The latest colors script still does
> not match in both cases.
>
> I have attached an updated version of the output of "colors" in both GNOME
> Terminal and in the Vim terminal window (vim at latest build).
>
> The point of interest is this: The color for yellow and for white is darker
> in the Vim terminal window. You can see this when positioning the
> screenshots side by side. I have noticed that other color schemes also show
> this same result (i.e., darker colors in Vim terminal). I will provide
> screenshots upon request. I don't know what might cause this... I did a git
> blame on the latest terminal.c file and I can't see anything with colors that
> seems odd.
>
> It may be that all of the colors here are slightly darker in the vim terminal
> window. It's so slight that it may be hard to tell. Again, a side-by-side
> comparison is the only way to really see this.
>
> I also want to note that showing bold text in bright colors has been disabled
> in GNOME Terminal.
>
> Thanks,
> Jason
I also noticed that the colors on Cygwin + mintty with 256-color mode are
wrong since 8.1.1146. Especially, yellow becomes brown.
The following patch seems to fix the problem:
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -2432,6 +2432,8 @@ color2index(VTermColor *color, int fg, i
if (color->ansi_index != VTERM_ANSI_INDEX_NONE)
{
+ if (t_colors == 256)
+ return color->ansi_index;
// The first 16 colors and default: use the ANSI index.
switch (color->ansi_index)
{
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/16349e9a-904c-465d-ad4d-424c94b217a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
