Hi,
GCC 9.1 warns this:
In file included from textprop.c:30:
textprop.c: In function 'join_prop_lines':
vim.h:1688:37: warning: 'props' may be used uninitialized in this function
[-Wmaybe-uninitialized]
1688 | # define mch_memmove(to, from, len) memmove((char*)(to), (char*)(from),
(size_t)(len))
| ^~~~~~~
textprop.c:1221:13: note: 'props' was declared here
1221 | char_u *props;
| ^~~~~
The following patch seems to solve the warning:
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -1240,9 +1240,12 @@ join_prop_lines(
if (line == NULL)
return;
mch_memmove(line, newp, len);
- l = oldproplen * sizeof(textprop_T);
- mch_memmove(line + len, props, l);
- len += l;
+ if (oldproplen > 0)
+ {
+ l = oldproplen * sizeof(textprop_T);
+ mch_memmove(line + len, props, l);
+ len += l;
+ }
for (i = 0; i < count - 1; ++i)
if (prop_lines[i] != NULL)
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/3def014c-d055-45e2-9803-222a6a07fa73%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
