Ken Takata wrote:
> 2019/6/8 Sat 19:05:45 UTC+9 Bram Moolenaar wrote:
> > Patch 8.1.1492
> > Problem: MS-Windows: when "!" is in 'guioptions' ":!start" fails.
> > Solution: Do not use a terminal window when the shell command begins with
> > "!start". (Yasuhiro Matsumoto, closes #4504)
> > Files: src/misc2.c, src/os_win32.c
>
> > --- 3251,3261 ----
> > /* The external command may update a tags file, clear cached tags. */
> > tag_freematch();
> >
> > ! if (cmd == NULL || *p_sxq == NUL
> > ! #if defined(FEAT_GUI_MSWIN) && defined(FEAT_TERMINAL)
> > ! || vim_strchr(p_go, GO_TERMINAL) != NULL
> > ! #endif
> > ! )
> > retval = mch_call_shell(cmd, opt);
> > else
> > {
>
> I think we need a check for gui.in_use for VIMDLL here:
>
> --- a/src/misc2.c
> +++ b/src/misc2.c
> @@ -3253,7 +3253,11 @@ call_shell(char_u *cmd, int opt)
>
> if (cmd == NULL || *p_sxq == NUL
> #if defined(FEAT_GUI_MSWIN) && defined(FEAT_TERMINAL)
> - || vim_strchr(p_go, GO_TERMINAL) != NULL
> + || (
> +# ifdef VIMDLL
> + gui.in_use &&
> +# endif
> + vim_strchr(p_go, GO_TERMINAL) != NULL)
> #endif
> )
> retval = mch_call_shell(cmd, opt);
Thanks!
--
"Microsoft is like Coke. It's a secret formula, all the money is from
distribution, and their goal is to get Coke everywhere. Open source is like
selling water. There are water companies like Perrier and Poland Spring, but
you're competing with something that's free." -- Carl Howe
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/201906081817.x58IHiVx021339%40masaka.moolenaar.net.
For more options, visit https://groups.google.com/d/optout.
