Hi Bram, On Wed, Jun 26, 2019 at 9:55 PM Bram Moolenaar <[email protected]> wrote: > > Yegappan wrote: > > > When multiple signs with icons are placed on the same line, then a > > different icon is drawn in the sign column using the > > netbeans_draw_multisign_indicator() function. > > This function draws the icon only if a netbeans connection is > > present (NETBEANS_OPEN). > > > > The screen line refresh function (win_line) always checks whether > > multiple signs are present on a line using the buf_signcount() function. > > This function counts the number of signs with icons placed on a line. > > This is done even though the netbeans connection is not present. > > If the netbeans connection is not present, then there is no need to > > count the number of signs as the multisign indicator will not be > > displayed. > > > > Does anyone see a problem if I change win_line() to call buf_signcount() > > only if the netbeans connection is present? > > I haven't checked the default, but in general the behavior should not > change by only compiling with netbeans, it should actually be using > netbeans. Which isn't very often these days. >
With this change, the default behavior is not changing. The unnecessary call to buf_signcount() is getting removed. The call to buf_signcount() is expensive and is not necessary. When multiple signs are placed on the same line, the attributes of the sign with the highest priority is used. This includes the icon of that sign. So this is a safe change. - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7m1CQwBACCiL162FEZh-eTqnP%3Df-r3U19P4TRmb4ynijw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
