Patch 8.1.1641
Problem: Garbage collection may run at a wrong moment. (Trygve Aaberge)
Solution: Postpone garbage collection while parsing messages. (closes #4620)
Files: src/misc2.c
*** ../vim-8.1.1640/src/misc2.c 2019-07-04 20:26:17.798397726 +0200
--- src/misc2.c 2019-07-07 13:51:35.678060572 +0200
***************
*** 4444,4455 ****
--- 4444,4462 ----
{
win_T *old_curwin = curwin;
int i;
+ int save_may_garbage_collect = may_garbage_collect;
// Do not handle messages while redrawing, because it may cause buffers to
// change or be wiped while they are being redrawn.
if (updating_screen)
return;
+ // may_garbage_collect is set in main_loop() to do garbage collection when
+ // blocking to wait on a character. We don't want that while parsing
+ // messages, a callback may invoke vgetc() while lists and dicts are in
use
+ // in the call stack.
+ may_garbage_collect = FALSE;
+
// Loop when a job ended, but don't keep looping forever.
for (i = 0; i < MAX_REPEAT_PARSE; ++i)
{
***************
*** 4485,4490 ****
--- 4492,4499 ----
break;
}
+ may_garbage_collect = save_may_garbage_collect;
+
// If the current window changed we need to bail out of the waiting loop.
// E.g. when a job exit callback closes the terminal window.
if (curwin != old_curwin)
*** ../vim-8.1.1640/src/version.c 2019-07-05 23:24:39.158501402 +0200
--- src/version.c 2019-07-07 13:54:11.801281201 +0200
***************
*** 779,780 ****
--- 779,782 ----
{ /* Add new patch number below this line */
+ /**/
+ 1641,
/**/
--
DEAD PERSON: I don't want to go in the cart!
CUSTOMER: Oh, don't be such a baby.
MORTICIAN: I can't take him...
DEAD PERSON: I feel fine!
CUSTOMER: Oh, do us a favor...
MORTICIAN: I can't.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/201907071205.x67C5pGw014362%40masaka.moolenaar.net.
For more options, visit https://groups.google.com/d/optout.
