On Fr, 12 Jul 2019, Bram Moolenaar wrote:
>
> Patch 8.1.1670
> Problem: Sign column not always properly aligned.
> Solution: Use "col" only after it was calculated. (Yee Cheng Chin,
> closes #4649)
> Files: src/gui.c
After this patch I see a warning when compiling with
-Wmaybe-uninitialized:
gui.c: In function ‘gui_outstr_nowrap’:
gui.c:2621:2: warning: ‘signcol’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
gui_mch_drawsign(gui.row, signcol, gui.highlight_mask);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I don't really see, how signcol can be used uninitialized, but to shut
up the compiler, I suggest this patch:
diff --git a/src/gui.c b/src/gui.c
index e66581f52..2d5f80fd2 100644
--- a/src/gui.c
+++ b/src/gui.c
@@ -2253,7 +2253,7 @@ gui_outstr_nowrap(
int col = gui.col;
#ifdef FEAT_SIGN_ICONS
int draw_sign = FALSE;
- int signcol;
+ int signcol = 0; // shut up unitialized warning
char_u extra[18];
# ifdef FEAT_NETBEANS_INTG
int multi_sign = FALSE;
Best,
Christian
--
Niemand urteilt schärfer als der Ungebildete, er kennt weder Gründe
noch Gegengründe.
-- Anselm Feuerbach
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/20190716151446.GA21013%40256bit.org.
For more options, visit https://groups.google.com/d/optout.
