John Marriott wrote:
> On 02-Aug-2019 19:35, Bram Moolenaar wrote:
> > Patch 8.1.1792
> > Problem: The vgetorpeek() function is too long.
> > Solution: Split off the part that handles mappings.
> > Files: src/getchar.c
>
> Hi All,
>
>
> I'm not sure if this warning (thrown by mingw64, gcc 9.1) was there
> before, but I only noticed it after this patch:
>
> ...
>
> gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DFEAT_GUI_MSWIN
> -DFEAT_CLIPBOARD -pipe -march=native -Wall -O3 -fomit-frame-pointer
> -freg-struct-return getchar.c -o gobjnative/getchar.o
> getchar.c: In function 'handle_mapping':
> getchar.c:2156:6: warning: 'keylen' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> 2156 | && keylen != KEYLEN_PART_MAP)
>
> ...
Hmm, maybe that is why the change made the tests flaky?
I could not reproduce the problem, thus I decided to revert the change.
If someone could try apllying it again and fixing this uninitialized
warning, perhaps the tests don't fail?
--
The Feynman problem solving Algorithm:
1) Write down the problem
2) Think real hard
3) Write down the answer
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/201908022117.x72LHKJc014466%40masaka.moolenaar.net.
