Hi,
2019/11/28 Thu 5:05:12 UTC+9 Christian Brabandt wrote:
>
>
> On Di, 26 Nov 2019, Bram Moolenaar wrote:
>
> > Patch 8.1.2344
> > Problem: Cygwin: warning for using strptime().
> > Solution: Move defining _XOPEN_SOURCE and __USE_XOPEN to vim.h. (Ken
> Takata,
> > closes #5265) Use 700 for _XOPEN_SOURCE for mkdtemp().
> > Files: src/os_unix.h, src/vim.h
>
> This still breaks on BSD like systems.
>
> How about the following patch on top of it?
>
> diff --git a/src/vim.h b/src/vim.h
> index 9b49ba1a9..c0053ce14 100644
> --- a/src/vim.h
> +++ b/src/vim.h
> @@ -36,8 +36,8 @@
> Error: configure did not run properly. Check auto/config.log.
> # endif
>
> -# if defined(UNIX) && !defined(MACOS_X)
> -// Needed for strptime(). Needs to be done early, since header files can
> +# if defined(UNIX) && !defined(MACOS_X) && !defined(__unix__)
> +// Needed for strptime() on Cygwin. Needs to be done early, since header
> files can
> // include other header files and end up including time.h, where these
> symbols
> // matter for Vim.
> // 700 is needed for mkdtemp().
>
__unix__ is also defined on Cygwin. So, the warning will occur again.
The original issue looks Cygwin specific, so using __CYGWIN__ might be
better:
#ifdef __CYGWIN__
// Needed for strptime() on Cygwin. Needs to be done early, since
header files can
...
Then os_unix.h needs to be reverted before 8.1.2344?
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/18b944ec-5c5c-4bd2-bfed-597b9f393850%40googlegroups.com.
