On 02-Dec-2019 00:22, Bram Moolenaar wrote:
John Marriott wrote:

On 01-Dec-2019 08:48, Bram Moolenaar wrote:
Patch 8.1.2371
Problem:    FEAT_TEXT_PROP is a confusing name.
Solution:   Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291)
Files:      runtime/doc/popup.txt, src/beval.c, src/buffer.c, src/change.c,
              src/drawline.c, src/drawscreen.c, src/edit.c, src/eval.c,
              src/evalbuffer.c, src/evalfunc.c, src/evalwindow.c, src/ex_cmds.c,
              src/ex_docmd.c, src/feature.h, src/fileio.c, src/getchar.c,
              src/globals.h, src/gui.c, src/gui_w32.c, src/indent.c,
              src/insexpand.c, src/macros.h, src/main.c, src/memline.c,
              src/misc2.c, src/mouse.c, src/move.c, src/ops.c, src/option.h,
              src/optiondefs.h, src/optionstr.c, src/popupmenu.c,
              src/popupwin.c, src/proto.h, src/screen.c, src/search.c,
              src/sign.c, src/structs.h, src/tag.c, src/testdir/runtest.vim,
              src/testdir/test_execute_func.vim, src/testdir/test_popupwin.vim,
              src/testdir/test_popupwin_textprop.vim, src/textprop.c, src/ui.c,
              src/version.c, src/vim.h, src/window.c


After this patch, mingw64 throws these errors if FEAT_QUICKFIX is not
defined:
I can see why the errors are given, but I do not see how this patch
would have caused this.

How do you get this combination of features?  Do you use small features
and define FEAT_PROP_POPUP or do you use normal and somehow disable
quickfix?

I can make the build pass with a few #ifdef adjustments, but a lot of
tests will fail.


For this windows build I want the smallest gui possible, so I start with a normal build and then disable a bunch of features I don't need (via a script). What happened here is that the feature name changed and I didn't update the script. So it tried to compile with my weird combination of features but with the FEAT_PROP_POPUP feature unexpectedly enabled. Whoops!

For the record, here is the (updated) list of features I disable for this build: FEAT_ARABIC FEAT_CLIENTSERVER FEAT_CONCEAL FEAT_CRYPT FEAT_DIGRAPHS FEAT_EMACS_TAGS FEAT_FLOAT FEAT_FOLDING FEAT_KEYMAP FEAT_LANGMAP FEAT_LISP FEAT_LOCALMAP FEAT_MULTI_LANG FEAT_PATH_EXTRA FEAT_PERSISTENT_UNDO FEAT_PROFILE FEAT_PROP_POPUP FEAT_QUICKFIX FEAT_RELTIME FEAT_RIGHTLEFT FEAT_SESSION FEAT_SMARTINDENT FEAT_SPELL FEAT_TAG_OLDSTATIC FEAT_TERMGUICOLORS FEAT_TERM_POPUP_MENU FEAT_VIMINFO FEAT_WILDIGN STARTUPTIME

I should have checked before posting and wasting everyone's time. Sorry!

Cheers
John

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/1a0c04e3-f09c-3468-3a24-ea9593b874b3%40internode.on.net.

Raspunde prin e-mail lui