Christian Brabandt <[email protected]> wrote:

> On Fr, 27 Dez 2019, Bram Moolenaar wrote:
>
> > Patch 8.2.0049
> > Problem:    Command line completion not fully tested.
> > Solution:   Add more test cases.  Make help sorting stable. (Dominique 
> > Pelle,
> >             closes #5402)
> [...]
> > + func Test_cmdline_complete_bang()
> > +   if executable('whoami')
> > +     return
> > +   endif
> > +   call feedkeys(":!whoam\<C-A>\<C-B>\"\<CR>", 'tx')
> > +   call assert_match('^".*\<whoami\>', @:)
> > + endfunc
>
> That condition is backwards.
>
> Best
> Christian

Thanks.  You're right. At first I could not see it.
But the line `if executable('whoami')` should of course
be `if !executable('whoami')`.  This is the piece
of code that is not covered as a result:

https://codecov.io/gh/vim/vim/src/297610ba4b110c918ffe60c45eb4a1d6ea2daae5/src/cmdexpand.c#L1270

Regards
Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAON-T_jWAGSobPLHH8uzJM0VjdYdYOwDgW9onyL_nrbbJ3ORfQ%40mail.gmail.com.

Raspunde prin e-mail lui