Yegappan wrote:
> On Sat, Mar 14, 2020 at 10:07 AM Dominique Pellé <[email protected]> > wrote: > > > Bram Moolenaar <[email protected]> wrote: > > > > > Yegappan wrote: > > > > > > > I see that the code coverage has gone down from 84.55% to 84.29% > > > > after patch 8.2.0377 (no CI test for a big-endian system). I am not > > sure > > > > how enabling additional builds reduced the code coverage. > > > > > > Indeed. The "tracked lines" did not change, the "Lines hit" did go > > > down. No idea how adding another configuration can cause that. > > > > > > You could perhaps dig deeper into what "lines hit" disappeared: > > > before: > > > > > https://codecov.io/gh/vim/vim/tree/8210693795d6d0d51bf5b70674d4539cdde0330b > > > after: > > > > > https://codecov.io/gh/vim/vim/tree/d47e6f0b4cc82e3ccdc4605bb1811861a5b2d115 > > > > It seems to be mostly GUI and X clipboard code that > > is now less covered. > > > > In the diff of patch 8.2.0377 I see: > > > > ``` > > @@ -73,9 +73,13 @@ anchors: > > fi > > before_script: > > # Start virtual framebuffer to be able to test the GUI. Does > > not work on OS X. > > - - export DISPLAY=:99.0 > > - - sh -e /etc/init.d/xvfb start && sleep 3 > > - - sudo modprobe snd-dummy > > + - | > > + if [[ "${TEST}" =~ gui ]]; then > > + export DISPLAY=:99.0 > > + sh -e /etc/init.d/xvfb start && sleep 3 > > + fi > > + - | > > + [ "${TRAVIS_CPU_ARCH}" = s390x ] || sudo modprobe snd-dummy > > - sudo usermod -a -G audio $USER > > - do_test() { sg audio "sg $(id -gn) '$*'"; } > > ``` > > > > It might be elated to that. Perhaps we don't enter > > the 'if' branch for any platform? > > > > I think, even in non-gui builds, some of the code path (e.g. clipboard) > depend on the DISPLAY being set. if_xcmdsrv.c test also has lower coveage. > I don't know whether this change is relevant to enabling the s390 builds. > This change should be reverted as this reduces the code coverage. Can you make a pull request for putting back the DISPLAY setting? -- hundred-and-one symptoms of being an internet addict: 271. You collect hilarious signatures from all 250 mailing lists you are subscribed to. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202003151811.02FIBDHv013960%40masaka.moolenaar.net.
