Hi Gary, On Mon, Jun 8, 2020 at 5:17 PM Gary Johnson <[email protected]> wrote:
> On 2020-06-08, Yegappan Lakshmanan wrote: > > Hi Gary, > > > > On Mon, Jun 8, 2020 at 4:30 PM Gary Johnson <[email protected]> wrote: > > > > I've been keeping Christian Brabandt's enable_spellchecking patch up > > to date since he originally posted it to vim_dev on August 5, 2012 > > ("Suggestion: allow 'z=' when spell-checking isn't on"). I haven't > > seen any problems with it in all that time, so I thought I'd update > > the documentation and tests as well and try to have it incorporated > > into mainstream Vim. The patch against version 8.2.935 is attached > > > > The patch allows the z= command and the spellbadword() and > > spellsuggest() functions to work even when 'spell' is disabled. > > Having the z= command available all the time is very handy for quick > > spelling checks. > > > > > > > > Is it possible to create a PR out of this diff so that it passes the CI > tests? > > (Maybe Christian can create the PR). > > Either way, having Christian do it or me do it, is fine with me. > It's probably better in the long term if I do it, if that's now the > preferred way. I've never submitted anything to this project that > way. Where would I find instructions? > > Regards, > Gary > > I use the following steps (assuming you have a github account, familiar with Git and have created a Vim repository clone in your account). $ mkdir spellcheck $ cd spellcheck $ git clone https://github.com/<user>/vim $ cd vim $ git checkout -b spellcheck $ git push origin spellcheck $ git branch --set-upstream-to=origin/spellcheck spellcheck Make the changes to the source code, build the image and test. Note that I use separate branches to work on different sets of changes. After making and testing the changes, you can push them to github using: $ git add <list of files> $ git commit -m <comment> $ git push origin spellcheck To create the pull request, in the github page (http://github.com/ <user>/vim), go to the spellcheck branch and click on the "New pull request" button. This will create a pull request and run the various tests. Check the following pages for the status of the tests: https://travis-ci.org/github/vim/vim/pull_requests https://ci.appveyor.com/project/chrisbra/vim/history https://cirrus-ci.com/vim/vim Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7npozhbDswZaQQ0ABFRw-8b4Lw3zmrvR7a0KLqvZi5u0Q%40mail.gmail.com.
