On Wed, Sep 16, 2020 at 9:42 AM Bram Moolenaar <[email protected]> wrote:
> > Michael Soyka wrote: > > > Using Make_ming.mak, the "tinytests" collection of build tests will fail > if > > the associated .ok file has Windows line endings. This happens because > the > > test.out file is explicitly set to have unix/linux line endings but the > .ok > > file has not been converted and so "diff" concludes they're different. > I > > have attached a patch which converts the .ok file and cleans-up. > > > > This was introduced by patch v8.2.1439 which removed the "fixff" > target. I > > noticed it because I use git-for-windows and its default is to use > Windows > > line endings in the workspace. > > > > I suspect the same problem occurs in Make_dos.mak but I have no way of > > verifying that. > > I had been wondering if "fixff" would still be needed. The very old > reason was that after unpacking the source tar archive some versions of > tar would change the line endings. So git-for-windows does the same > thing? Or should we somehow set the git metadata so that it doesn't > change the line endings? > > Assuming there is a preferred line ending for the tinytests, how can you then force it on the end-user? For git, I think the .gitattributes file is the way forward but what about Mercurial, tar-files, and whatever other distribution methods you support? It is also unclear to me what determines the fileformat of the test.out files created by the tests. For diff to work, it needs to be the same as the .ok file. For these reasons, I think that your only choice is to control it in the Makefiles. As to the preferred line ending, I suspect it should be LF but I don't know if that is appropriate for non-Windows and non-linux systems. -- > Communication is one of the most compli..., eh, well, it's hard. > You know what I mean. Not? > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ > \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CADM3x7zO%3DCj7gGLP3LbCzqxM%2BMnXGh40uRsgU%3D54rDaLSUTBVA%40mail.gmail.com.
