On 09/22/2020 4:34 AM, Bram Moolenaar wrote:
Michael Soyka wrote:
I do not see any reference to testdir/Make_ming.mak from any of the
Makefiles in the src directory.
The src/Make_cyg_ming.mak file does not even have a "test" target.
Only src/Make_mvc.mak refers to testdir/Make_dos.mak.
Have you been using testdir/Make_ming.mak only directly?
Yes. I "cd testdir" and then "mingw32-make -f Make_ming.mak ..." .
It would be useful to add a test target in src/Make_cyg_ming.mak, then
"make test" in the src directory should work.
I can add another commit that does that.
Perhaps one of the Github MinGW actions can be changed to use the ming
test makefile.
At the present time, I have no idea how to do that. Perhaps another
could do it or provide some guidance to me so I could do it.
By the way, I've now made similar modifications to Make_dos.mak but do not
have Visual Studio.
Would you like me to push that to github as well?
If I do push it to github, do I then need to submit another pull request?
Sorry for the questions but this is my first time using github and pull
requests.
I'm not sure if we want to change Make_dos.mak. It's working find as it
is, changing the handling of line endings can only break it.
Since my last post I've downloaded Visual Studio and successfully run
"tinytests" with nmake and my Make_dos.mak changes against vim with tiny
features. In my opinion, the changes work and apparently do no harm.
Your call.
I suppose one other consideration is that these are old style tests
which may ultimately be upgraded to the new style, in which case, this
whole effort will have a short life.
-mike
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/2df8367c-7f73-e925-8bed-7a53d39e6635%40cox.net.
