Hi, On Mon, Sep 28, 2020 at 9:03 AM markonm <[email protected]> wrote:
> Thank you for the patch. I can see a big improvement in initial test. > > v8.2.1767 with qfexpand.diff outputs: > > setqflist: 0.011608 > copen: 0.012365 > setqflist: 0.019360 > > I also made a new test. This one has 46947 entries spread across 2307 > files. The old one had 10000 entries and only 1 file. > > " measureQuickFix2.vim > silent grep! /S "file" * > let qf = getqflist() > > let start = reltime() > call setqflist(qf) > echom 'setqflist:' reltimestr(reltime(start)) > > let start = reltime() > silent copen > echom 'copen: ' reltimestr(reltime(start)) > > let start = reltime() > call setqflist(qf) > echom 'setqflist:' reltimestr(reltime(start)) > > Steps used: > > 1. git clone --depth 1 https://github.com/vim/vim > 2. cd vim > 3. gvim --clean -S measureQuickFix2.vim > > It produced the following output: > > v8.0.1780 > > setqflist: 0.053862 > copen: 0.031189 > setqflist: 0.084630 > > v8.0.1781 > > setqflist: 0.052574 > copen: 15.808420 > setqflist: 16.696758 > > v8.2.1767 > > setqflist: 0.059002 > copen: 16.761416 > setqflist: 16.750146 > > v8.2.1767 with qfexpand.diff > > setqflist: 0.058875 > copen: 0.916748 > setqflist: 0.946482 > > Although the patch greatly improves performance, interaction with quickfix > is still a bit slower than in v8.0.1780. > > > The changes made by 1781 fixes the issue reported in https://github.com/vim/vim/issues/2846 This change shortens the file name for each buffer. So the overhead of doing this will increase the time it takes to populate a quickfix list or to display the entries in the quickfix buffer (proportional to the number of unique buffers in the quickfix list). We can try to optimize the time it takes to shorten the buffer name. But we won't be able to get back to the same time as before this change. Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7nMenFqu6i3fFyZ_09RAQuTcvRamC0d5_ujok9iWsaJgA%40mail.gmail.com.
