Patch 8.2.1839
Problem: Vim9: memory leaks reported in assign test.
Solution: Move the failing job_start() call to separate test files, it
causes false leak reports.
Files: src/testdir/test_vim9_assign.vim, src/testdir/test_vim9_fails.vim,
src/testdir/Make_all.mak
*** ../vim-8.2.1838/src/testdir/test_vim9_assign.vim 2020-10-10
15:37:54.190275246 +0200
--- src/testdir/test_vim9_assign.vim 2020-10-11 23:36:23.864017175 +0200
***************
*** 75,81 ****
if has('channel')
var chan1: channel
var job1: job
! var job2: job = job_start('willfail')
endif
if has('float')
var float1: float = 3.4
--- 75,81 ----
if has('channel')
var chan1: channel
var job1: job
! # calling job_start() is in test_vim9_fails.vim, it causes leak reports
endif
if has('float')
var float1: float = 3.4
***************
*** 216,227 ****
CheckDefFailure(['v:errmsg += "more"'], 'E1051:')
CheckDefFailure(['v:errmsg += 123'], 'E1012:')
! # this should not leak
! if 0
! var text =<< trim END
! some text
! END
! endif
enddef
def Test_extend_list()
--- 216,224 ----
CheckDefFailure(['v:errmsg += "more"'], 'E1051:')
CheckDefFailure(['v:errmsg += 123'], 'E1012:')
! var text =<< trim END
! some text
! END
enddef
def Test_extend_list()
*** ../vim-8.2.1838/src/testdir/test_vim9_fails.vim 2020-10-12
20:30:36.923814443 +0200
--- src/testdir/test_vim9_fails.vim 2020-10-11 23:26:12.617898491 +0200
***************
*** 0 ****
--- 1,10 ----
+ " Test for Vim9 script with failures, causing memory leaks to be reported.
+ " The leaks happen after a fork() and can be ignored.
+
+ def Test_assignment()
+ if has('channel')
+ var chan1: channel
+ var job1: job
+ var job2: job = job_start('willfail')
+ endif
+ enddef
*** ../vim-8.2.1838/src/testdir/Make_all.mak 2020-09-22 20:33:30.437223175
+0200
--- src/testdir/Make_all.mak 2020-10-11 23:29:27.717300634 +0200
***************
*** 34,39 ****
--- 34,40 ----
test_vim9_cmd \
test_vim9_disassemble \
test_vim9_expr \
+ test_vim9_fails \
test_vim9_func \
test_vim9_script
***************
*** 42,47 ****
--- 43,49 ----
test_vim9_cmd.res \
test_vim9_disassemble.res \
test_vim9_expr.res \
+ test_vim9_fails.res \
test_vim9_func.res \
test_vim9_script.res
*** ../vim-8.2.1838/src/version.c 2020-10-11 21:34:37.115264199 +0200
--- src/version.c 2020-10-12 20:29:59.895907787 +0200
***************
*** 752,753 ****
--- 752,755 ----
{ /* Add new patch number below this line */
+ /**/
+ 1839,
/**/
--
If bankers can count, how come they have eight windows and
only four tellers?
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202010121831.09CIVutX141081%40masaka.moolenaar.net.
