Hi Bram,

On Fri, Nov 6, 2020 at 1:01 PM Bram Moolenaar <[email protected]>
wrote:

> Thanks for looking into this. Obviously avoiding memory access errors is
> important. That some memory is release only later (perhaps much later) is
> less important.
> if you know how to fix it that is welcome, but only if there is no risk of
> breaking something else.
>
> Hmm, perhaps it should be:
> #define NETBEANS_OPEN ((nb_channel) != NULL &&
> channel_can_write_to(nb_channel))
> No, channel_can_write_to() checks for the NULL pointer, thus that's not
> needed.
>
> Or were you referring to what happens in netbeans_file_killed() ?
>
>
> Yes. I am referring to the netbeans_file_killed() function. If the netbeans
connection is not open, then this function will not cleanup the buffer
reference. Later when the netbeans connection is closed using nbclose,
it will try to access the dangling buffer pointer.

We can modify this function to always cleanup the buffer reference even
if the netbeans connection is closed.

- Yegappan

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAAW7x7%3D8d6p_-DGKBPyQ%2BghzchzY3QuQP0fcTTNkAQ6%3Dj2DYCg%40mail.gmail.com.

Raspunde prin e-mail lui